timers: add helper fn for async init #18825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently 3 places in Timers where the exact same code appears. Instead create a helper function that does the same job of setting asyncId & triggerAsyncId, as well as calling emitInit.
nodejs-github-bot
added
the
timers
Contributor
Author
BridgeAR
approved these changes
Feb 16, 2018
lib/internal/timers.js
Outdated
| return timers; | ||
| } | ||
|
|
||
| function initAsyncResource(resource, type = 'Timeout') { |
Member
There was a problem hiding this comment.
Non-blocking nit: I personally would remove the default and always pass in the value explicitly.
Contributor
Author
There was a problem hiding this comment.
Sure, I was undecided on whether to do this or not so adjusted now.
BridgeAR
added
the
author ready
jasnell
approved these changes
Feb 16, 2018
lpinca
approved these changes
Feb 17, 2018
Contributor
Author
|
Landed in 28f3ffb |
apapirovski
added a commit
that referenced
this pull request
Feb 19, 2018
There are currently 3 places in Timers where the exact same code appears. Instead create a helper function that does the same job of setting asyncId & triggerAsyncId, as well as calling emitInit. PR-URL: #18825 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
|
Should this be backported to |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
There are currently 3 places in Timers where the exact same code appears. Instead create a helper function that does the same job of setting asyncId & triggerAsyncId, as well as calling emitInit. PR-URL: nodejs#18825 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
|
This should likely be included in a larger backport of timers to v8.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 3 places in Timers where this exact same code appears. Instead create a helper function that does the same job.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
timers