Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
e304c42
test: add unhandled rejection guard
babygoat Nov 23, 2017
887dcb9
test: remove literals that obscure assert messages
Trott Dec 13, 2017
bba1442
n-api: fix memory leak in napi_async_destroy()
Dec 17, 2017
bcbb7af
test: remove ambiguous error messages from test_error
nadrane Dec 21, 2017
6bf3769
doc: updates examples to use NULL
mhdawson Jan 5, 2018
f81330f
n-api: throw RangeError in napi_create_dataview() with invalid range
romandev Dec 26, 2017
6d23c24
n-api: expose n-api version in process.versions
mhdawson Jan 9, 2018
40ce083
doc: napi: fix unbalanced emphasis
ofrobots Jan 12, 2018
621117e
doc: napi: make header style consistent
ofrobots Jan 12, 2018
111678b
n-api: throw RangeError napi_create_typedarray()
romandev Jan 8, 2018
94618a5
test: fixed typos in napi test
furstenheim Jan 14, 2018
375d043
doc: remove uannecessary Require
mhdawson Jan 16, 2018
f7fb0c3
timers: allow Immediates to be unrefed
apapirovski Jan 13, 2018
23fd460
test: refactor addons-napi/test_exception/test.js
Trott Jan 24, 2018
021e4a4
n-api: change assert ok check to notStrictEqual.
nbdaaron Jan 27, 2018
bf96235
test: show pending exception error in napi tests
blairwilcox Jan 27, 2018
17862cd
n-api: implement wrapping using private properties
Jan 23, 2018
29bbf0c
n-api: wrap control flow macro in do/while
bnoordhuis Feb 2, 2018
6619a1b
doc: remove usage of you in n-api doc
mhdawson Feb 2, 2018
8923ad5
doc: small typo in n-api.md
iSkore Feb 4, 2018
ed8ac32
n-api: add methods to open/close callback scope
mhdawson Dec 13, 2017
01b28fa
n-api: remove extra reference from test
Feb 3, 2018
d2f0672
doc: fix typo in n-api.md
vsemozhetbyt Feb 6, 2018
9c20b87
test: improve error message output
bshankar Feb 1, 2018
ef50323
test: convert new tests to use error types
jackhorton Feb 5, 2018
c4592e6
doc: fix exporting a function example
Feb 8, 2018
5ab4d31
doc: mark NAPI_AUTO_LENGTH as code
tniessen Feb 10, 2018
a1df466
test: remove unnecessary timer
cjihrig Feb 11, 2018
eb85cd8
n-api: fix object test
Feb 27, 2018
2b3207d
doc: fix n-api asynchronous threading docs
ebickle Mar 1, 2018
7a80a8d
n-api: update reference test
Mar 2, 2018
de2d3a6
n-api: update documentation
Mar 1, 2018
a92796e
n-api: resolve promise in test
Mar 8, 2018
2cfd4fe
n-api,test: add a new.target test to addons-napi
boingoing Jan 17, 2018
4a0fc8a
n-api,test: add int64 bounds tests
kfarnung Mar 12, 2018
ff968b7
doc: fix typos on n-api
shama Mar 16, 2018
01790d4
n-api: add missing exception checking
mhdawson Mar 15, 2018
a19b829
n-api: separate out async_hooks test
Mar 16, 2018
9b1b810
n-api: add napi_fatal_exception
mafintosh Mar 14, 2018
3a50835
n-api: re-write test_make_callback
Mar 19, 2018
b25dec8
doc: Add a missing comma
leaves4j Mar 23, 2018
c33daa4
n-api: bump version of n-api supported
mhdawson Mar 20, 2018
65b06de
n-api: ensure in-module exceptions are propagated
Mar 22, 2018
e3a2737
n-api: back up env before finalize
Apr 1, 2018
d73e802
n-api: add more `int64_t` tests
kfarnung Mar 16, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: updates examples to use NULL
Examples in the N-API doc used a mix of nullptr and NULL.
We should be consistent and because N-API is a 'C' API I believe
using NULL is better.  This will avoid any potential confusion
as to whether N-API can be used with plain C.

PR-URL: #18008
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
  • Loading branch information
mhdawson authored and Gabriel Schulhof committed Apr 12, 2018
commit 6bf376935e52ae5ca2c2088c936336ffc35ef9ab
32 changes: 16 additions & 16 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -905,9 +905,9 @@ napi_value Init(napi_env env, napi_value exports) {
napi_status status;
napi_property_descriptor desc =
{"hello", Method, 0, 0, 0, napi_default, 0};
if (status != napi_ok) return nullptr;
if (status != napi_ok) return NULL;
status = napi_define_properties(env, exports, 1, &desc);
if (status != napi_ok) return nullptr;
if (status != napi_ok) return NULL;
return exports;
}
```
Expand All @@ -919,7 +919,7 @@ napi_value Init(napi_env env, napi_value exports) {
napi_value method;
napi_status status;
status = napi_create_function(env, "exports", Method, NULL, &method));
if (status != napi_ok) return nullptr;
if (status != napi_ok) return NULL;
return method;
}
```
Expand All @@ -932,21 +932,21 @@ For example, to define a class so that new instances can be created
napi_value Init(napi_env env, napi_value exports) {
napi_status status;
napi_property_descriptor properties[] = {
{ "value", nullptr, GetValue, SetValue, 0, napi_default, 0 },
{ "value", NULL, GetValue, SetValue, 0, napi_default, 0 },
DECLARE_NAPI_METHOD("plusOne", PlusOne),
DECLARE_NAPI_METHOD("multiply", Multiply),
};

napi_value cons;
status =
napi_define_class(env, "MyObject", New, nullptr, 3, properties, &cons);
if (status != napi_ok) return nullptr;
napi_define_class(env, "MyObject", New, NULL, 3, properties, &cons);
if (status != napi_ok) return NULL;

status = napi_create_reference(env, cons, 1, &constructor);
if (status != napi_ok) return nullptr;
if (status != napi_ok) return NULL;

status = napi_set_named_property(env, exports, "MyObject", cons);
if (status != napi_ok) return nullptr;
if (status != napi_ok) return NULL;

return exports;
}
Expand Down Expand Up @@ -2364,8 +2364,8 @@ if (status != napi_ok) return status;

// Set the properties
napi_property_descriptor descriptors[] = {
{ "foo", nullptr, 0, 0, 0, fooValue, napi_default, 0 },
{ "bar", nullptr, 0, 0, 0, barValue, napi_default, 0 }
{ "foo", NULL, 0, 0, 0, fooValue, napi_default, 0 },
{ "bar", NULL, 0, 0, 0, barValue, napi_default, 0 }
}
status = napi_define_properties(env,
obj,
Expand Down Expand Up @@ -2876,18 +2876,18 @@ object. A sample module might look as follows:
```C
napi_value SayHello(napi_env env, napi_callback_info info) {
printf("Hello\n");
return nullptr;
return NULL;
}

napi_value Init(napi_env env, napi_value exports) {
napi_status status;

napi_value fn;
status = napi_create_function(env, nullptr, 0, SayHello, nullptr, &fn);
if (status != napi_ok) return nullptr;
status = napi_create_function(env, NULL, 0, SayHello, nullptr, &fn);
if (status != napi_ok) return NULL;

status = napi_set_named_property(env, exports, "sayHello", fn);
if (status != napi_ok) return nullptr;
if (status != napi_ok) return NULL;

return exports;
}
Expand Down Expand Up @@ -2952,7 +2952,7 @@ napi_status napi_get_new_target(napi_env env,
Returns `napi_ok` if the API succeeded.

This API returns the `new.target` of the constructor call. If the current
callback is not a constructor call, the result is `nullptr`.
callback is not a constructor call, the result is `NULL`.

### *napi_new_instance*
<!-- YAML
Expand Down Expand Up @@ -3034,7 +3034,7 @@ reference to the class constructor for later `instanceof` checks.
As an example:

```C
napi_value MyClass_constructor = nullptr;
napi_value MyClass_constructor = NULL;
status = napi_get_reference_value(env, MyClass::es_constructor, &MyClass_constructor);
assert(napi_ok == status);
bool is_instance = false;
Expand Down