Skip to content

node_api: add napi_fatal_exception #19337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

node_api: add napi_fatal_exception #19337

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fefdda
n-api: test uncaught exception in worker
mafintosh Mar 14, 2018
e602e9c
n-api: fix fatalexception handling in workers
mafintosh Mar 14, 2018
a575495
n-api: add napi_fatal_exception
mafintosh Mar 14, 2018
de3c603
TBA -> REPLACEME
mafintosh Mar 14, 2018
aa5498b
add test and support passing in an error
mafintosh Mar 15, 2018
5ff7ba4
use inline fun instead of macro
mafintosh Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
n-api: test uncaught exception in worker
  • Loading branch information
@mafintosh
mafintosh committed Mar 14, 2018
commit 7fefdda4b21ad035719f1e378b0018be9795b481
18 changes: 18 additions & 0 deletions test/addons-napi/test_async/test-uncaught.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
const common = require('../../common');
const assert = require('assert');
const test_async = require(`./build/${common.buildType}/test_async`);

process.on('uncaughtException', common.mustCall(function(err) {
try {
throw new Error('should not fail');
} catch (err) {
assert.strictEqual(err.message, 'should not fail');
}
assert.strictEqual(err.message, 'uncaught');
}));

// Successful async execution and completion callback.
test_async.Test(5, {}, common.mustCall(function() {
throw new Error('uncaught');
}));