Skip to content

n-api: bump version of n-api supported #19497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

n-api: bump version of n-api supported #19497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
n-api: bump version of n-api supported 
Bump the version due to additions to the api.
  • Loading branch information
@mhdawson
mhdawson committed Mar 20, 2018
commit c28a7b13870be5bfb5b234bac737dee29c53984c
2 changes: 1 addition & 1 deletion src/node_version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,6 @@
#define NODE_MODULE_VERSION 62

// the NAPI_VERSION provided by this version of the runtime
#define NAPI_VERSION 2
#define NAPI_VERSION 3

#endif // SRC_NODE_VERSION_H_
4 changes: 2 additions & 2 deletions test/addons-napi/test_general/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ assert.notStrictEqual(test_general.testGetPrototype(baseObject),
test_general.testGetPrototype(extendedObject));

// test version management functions
// expected version is currently 1
assert.strictEqual(test_general.testGetVersion(), 2);
// expected version is currently 3
assert.strictEqual(test_general.testGetVersion(), 3);

const [ major, minor, patch, release ] = test_general.testGetNodeVersion();
assert.strictEqual(process.version.split('-')[0],
Expand Down