Skip to content

test: removed third argument from assert.strictEqual() #19707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: removed third argument from assert.strictEqual() #19707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: removed third argument from assert.strictEqual() 
If there is an AssertionError, the string literal is printed and not the
value of `r`. For debugging purposes, it is good to know if `r` is false
or null or something else.
  • Loading branch information
@Axxxx0n
Axxxx0n committed Mar 30, 2018
commit 08011ce9e41e7db319687b246671c20595a5baf1
3 changes: 2 additions & 1 deletion test/parallel/test-http-res-write-after-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ const server = http.Server(common.mustCall(function(req, res) {
res.end();

const r = res.write('This should raise an error.');
assert.strictEqual(r, true, 'write after end should return true');
// write after end should return true
assert.strictEqual(r, true);
}));

server.listen(0, function() {
Expand Down