Skip to content

deps: cherry-pick 39d546a from upstream v8 #20016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

deps: cherry-pick 39d546a from upstream v8 #20016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8776d2
deps: cherry-pick 39d546a from upstream V8
devsnek Apr 13, 2018
8daa1c9
util: introduce types.isModuleNamespaceObject
devsnek Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
util: introduce types.isModuleNamespaceObject
  • Loading branch information
@devsnek
devsnek committed Apr 15, 2018
commit 8daa1c90ff7e5cc25b8a90a83cda43f8f56bb68f
1 change: 1 addition & 0 deletions src/node_types.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ namespace {
V(SharedArrayBuffer) \
V(Proxy) \
V(WebAssemblyCompiledModule) \
V(ModuleNamespaceObject) \


#define V(type) \
Expand Down
10 changes: 9 additions & 1 deletion test/parallel/test-util-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Flags: --harmony-bigint
// Flags: --harmony-bigint --experimental-vm-modules
/* global SharedArrayBuffer */
'use strict';
const common = require('../common');
Expand Down Expand Up @@ -126,3 +126,11 @@ for (const [ value, _method ] of [
assert.deepStrictEqual(yup, expected[testedFunc]);
}
}

(async () => {
const m = new vm.Module('');
await m.link(() => 0);
m.instantiate();
await m.evaluate();
assert.ok(types.isModuleNamespaceObject(m.namespace));
})();