Skip to content

doc: added explicitly that the close event does not take arguments #20031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

doc: added explicitly that the close event does not take arguments #20031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83008db
doc: added explicitly that the close event does not take arguments
indranil Apr 14, 2018
158aeb4
doc: changed wording to better state listener
indranil Apr 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: added explicitly that the close event does not take arguments 
Explicitly added in the docs that the close event does not expect
any arguments when invoked.

Fixes: #20018
  • Loading branch information
@indranil
indranil committed Apr 14, 2018
commit 83008dbe4005bc15e5356fb6104d3b299abece6b
3 changes: 2 additions & 1 deletion doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ solely on the API of the `Http2Session`.
added: v8.4.0
-->

The `'close'` event is emitted once the `Http2Session` has been destroyed.
The `'close'` event is emitted once the `Http2Session` has been destroyed. It
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Apr 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Feel free to ignore, but maybe it would be a bit more clear if we write "Its listener does not expect any arguments"?

Copy link
Contributor Author

@indranil indranil Apr 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good idea. I edited the wording to reflect the change.

does not expect any arguments.

#### Event: 'connect'
<!-- YAML
Expand Down