Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f0ded20
src: cleanup per-isolate state on platform on isolate unregister
addaleax May 17, 2018
2bb055b
src: remove unused fields isolate_
danbev May 23, 2018
e7695cc
src: simplify handle closing
addaleax Sep 10, 2017
6d4931a
src: make handle onclose property a Symbol
addaleax Jun 2, 2018
315efb5
worker: implement `MessagePort` and `MessageChannel`
addaleax Sep 5, 2017
f2e297b
fixup! worker: implement `MessagePort` and `MessageChannel`
addaleax Jun 2, 2018
ef24c5c
worker: support MessagePort passing in messages
addaleax Oct 7, 2017
a57c54f
worker: add `SharedArrayBuffer` sharing
addaleax May 13, 2018
ca0edc1
src: remove unused fields msg_ and env_
danbev May 23, 2018
d2d9061
src: add Env::profiler_idle_notifier_started()
TimothyGu Sep 25, 2017
0c7012e
worker: initial implementation
addaleax Sep 1, 2017
396d785
fixup! worker: initial implementation
addaleax Jun 3, 2018
65d4542
fixup! worker: initial implementation
addaleax Jun 4, 2018
d0535eb
fixup! worker: initial implementation
addaleax Jun 5, 2018
17e01a2
test: add test against unsupported worker features
TimothyGu Sep 25, 2017
53b660b
worker: restrict supported extensions
TimothyGu Sep 20, 2017
004075b
worker: enable stdio
addaleax May 13, 2018
d44594d
benchmark: port cluster/echo to worker
TimothyGu Sep 24, 2017
fa53bd5
worker: improve error (de)serialization
addaleax Sep 25, 2017
79970f3
test,tools: enable running tests under workers
addaleax May 17, 2018
168d8a6
doc: explain Worker semantics in async_hooks.md
addaleax May 22, 2018
a12f76f
worker: rename to worker_threads
addaleax Jun 1, 2018
ab02dbc
fixup! worker: rename to worker_threads
addaleax Jun 3, 2018
2947dea
fixup! worker: rename to worker_threads
addaleax Jun 3, 2018
735227e
fixup! worker: rename to worker_threads
addaleax Jun 5, 2018
cbbddea
fixup! worker: rename to worker_threads
addaleax Jun 5, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: remove unused fields msg_ and env_
Currently the following compiler warnings are generated:

../src/node_messaging.cc:74:16:
warning: private field 'env_' is not used [-Wunused-private-field]
  Environment* env_;
               ^
../src/node_messaging.cc:75:12:
warning: private field 'msg_' is not used [-Wunused-private-field]
  Message* msg_;
           ^
2 warnings generated.

This commit removes these unused private members.
  • Loading branch information
danbev authored and addaleax committed Jun 5, 2018
commit ca0edc199390008c185f52ce4267a2c7f904ec9a
6 changes: 1 addition & 5 deletions src/node_messaging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
const std::vector<MessagePort*>& message_ports,
const std::vector<Local<SharedArrayBuffer>>&
shared_array_buffers)
: env_(env),
msg_(m),
message_ports_(message_ports),
: message_ports_(message_ports),
shared_array_buffers_(shared_array_buffers) {}

MaybeLocal<Object> ReadHostObject(Isolate* isolate) override {
Expand All @@ -71,8 +69,6 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
ValueDeserializer* deserializer = nullptr;

private:
Environment* env_;
Message* msg_;
const std::vector<MessagePort*>& message_ports_;
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers_;
};
Expand Down