tools,test: remove unused config hooks #22010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a couple of unused/empty functions inside of `tools/test.py`
nodejs-github-bot
added
test
BridgeAR
approved these changes
Jul 29, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Jul 30, 2018
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19567/ (edit: ✔️) |
|
Landed in 3b23b4d |
maclover7
added a commit
that referenced
this pull request
Jul 31, 2018
Removes a couple of unused/empty functions inside of `tools/test.py` PR-URL: #22010 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 1, 2018
Removes a couple of unused/empty functions inside of `tools/test.py` PR-URL: #22010 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a couple of unused/empty functions inside of
tools/test.pyChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes