Skip to content

test: improve reliability in http2-session-timeout #22026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: improve reliability in http2-session-timeout #22026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/sequential/test-http2-session-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');
const http2 = require('http2');

const serverTimeout = common.platformTimeout(200);
const callTimeout = common.platformTimeout(20);
const mustNotCall = common.mustNotCall();

const server = h2.createServer();
const server = http2.createServer();
server.timeout = serverTimeout;

server.on('request', (req, res) => res.end());
Expand All @@ -19,7 +18,7 @@ server.listen(0, common.mustCall(() => {
const port = server.address().port;

const url = `http://localhost:${port}`;
const client = h2.connect(url);
const client = http2.connect(url);
const startTime = process.hrtime();
makeReq();

Expand All @@ -37,7 +36,7 @@ server.listen(0, common.mustCall(() => {
const diff = process.hrtime(startTime);
const milliseconds = (diff[0] * 1e3 + diff[1] / 1e6);
if (milliseconds < serverTimeout * 2) {
setTimeout(makeReq, callTimeout);
setImmediate(makeReq);

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

} else {
server.removeListener('timeout', mustNotCall);
server.close();
Expand Down