Skip to content

test: add tests to check error in dns.lookupService. #22908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: add tests to check error in dns.lookupService. #22908

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6af2a7
test: add tests to check error in dns.lookupService.
Sep 17, 2018
81280ac
test: assign to a variable
Sep 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add tests to check error in dns.lookupService. 
Added tests to check error in dns.lookupService to
increase coverage.
  • Loading branch information
Masashi Hirano committed Sep 17, 2018
commit a6af2a7fab85a49044426cac2bdc0408e99f716b
19 changes: 19 additions & 0 deletions test/parallel/test-dns-lookupService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Flags: --expose-internals
'use strict';
const common = require('../common');
const assert = require('assert');
const { internalBinding } = require('internal/test/binding');
const cares = internalBinding('cares_wrap');
const dns = require('dns');

// Stub `getnameinfo` to *always* error.
cares.getnameinfo = () => internalBinding('uv').UV_ENOENT;
Copy link
Contributor

@thefourtheye thefourtheye Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: uv could be assigned to a variable.


assert.throws(
() => dns.lookupService('127.0.0.1', 80, common.mustNotCall()),
{
code: 'ENOENT',
message: 'getnameinfo ENOENT 127.0.0.1',
syscall: 'getnameinfo'
}
);