Skip to content

fs: flip value of isOpen #24390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fs: flip value of isOpen #24390

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b9808
fs: flip value of isOpen
Nov 16, 2018
9392d67
fs: inline typeof check
Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: flip value of isOpen
  • Loading branch information
dexterleng committed Nov 16, 2018
commit d8b9808ae0481f26e1c6ffef7d03012084de34f6
4 changes: 2 additions & 2 deletions lib/internal/fs/streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ ReadStream.prototype._read = function(n) {
};

ReadStream.prototype._destroy = function(err, cb) {
const isOpen = typeof this.fd !== 'number';
if (isOpen) {
const isOpen = typeof this.fd === 'number';
if (!isOpen) {
this.once('open', closeFsStream.bind(null, this, cb, err));
return;
}
Expand Down