Skip to content

test: replaced anonymous functions with closuers #24442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: replaced anonymous functions with closuers #24442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: replaced anonymous functions with closuers
  • Loading branch information
J. Rahul committed Nov 17, 2018
commit fa874b65579b13dea4638ea0242e10bfd49e393a
16 changes: 8 additions & 8 deletions test/parallel/test-tls-ticket-cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ if (cluster.isMaster) {
const c = tls.connect(workerPort, {
session: lastSession,
rejectUnauthorized: false
}, function() {
}, () => {
lastSession = c.getSession();
c.end();

Expand All @@ -60,7 +60,7 @@ if (cluster.isMaster) {

function fork() {
const worker = cluster.fork();
worker.on('message', function({ msg, port }) {
worker.on('message', ({ msg, port }) => {
console.error('[master] got %j', msg);
if (msg === 'reused') {
++reusedCount;
Expand All @@ -71,15 +71,15 @@ if (cluster.isMaster) {
}
});

worker.on('exit', function() {
worker.on('exit', () => {
console.error('[master] worker died');
});
}
for (let i = 0; i < workerCount; i++) {
fork();
}

process.on('exit', function() {
process.on('exit', () => {
assert.strictEqual(reqCount, expectedReqCount);
assert.strictEqual(reusedCount + 1, reqCount);
});
Expand All @@ -91,7 +91,7 @@ const cert = fixtures.readSync('agent.crt');

const options = { key, cert };

const server = tls.createServer(options, function(c) {
const server = tls.createServer(options, (c) => {
if (c.isSessionReused()) {
process.send({ msg: 'reused' });
} else {
Expand All @@ -100,7 +100,7 @@ const server = tls.createServer(options, function(c) {
c.end();
});

server.listen(0, function() {
server.listen(0, () => {
const { port } = server.address();
process.send({
msg: 'listening',
Expand All @@ -111,14 +111,14 @@ server.listen(0, function() {
process.on('message', function listener(msg) {
console.error('[worker] got %j', msg);
if (msg === 'die') {
server.close(function() {
server.close(() => {
console.error('[worker] server close');

process.exit();
});
}
});

process.on('exit', function() {
process.on('exit', () => {
console.error('[worker] exit');
});