Skip to content

Two URL parser fixes #24495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+66 −51
Closed

Two URL parser fixes #24495

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fed0e0
Revert "url: make the context non-enumerable"
TimothyGu Nov 13, 2018
6cf1769
src: set HAS_USERNAME/PASSWORD more strictly
TimothyGu Nov 13, 2018
8be84ac
url: reuse existing context in href setter
TimothyGu Nov 13, 2018
19634c7
url: simplify native URL object construction
TimothyGu Nov 20, 2018
61114b1
fixup! url: reuse existing context in href setter
TimothyGu Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! url: reuse existing context in href setter 
Fix linting
  • Loading branch information
@TimothyGu
TimothyGu committed Nov 20, 2018
commit 61114b1c1fa96c5b1424ccd6f6c02efef82c841e
8 changes: 4 additions & 4 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class URL {
}
this[context] = new URLContext();
parse(input, -1, base_context, undefined, onParseComplete.bind(this),
onParseError);
onParseError);
}

get [special]() {
Expand Down Expand Up @@ -440,7 +440,7 @@ Object.defineProperties(URL.prototype, {
// toUSVString is not needed.
input = `${input}`;
parse(input, -1, undefined, undefined, onParseComplete.bind(this),
onParseError);
onParseError);
}
},
origin: { // readonly
Expand Down Expand Up @@ -487,7 +487,7 @@ Object.defineProperties(URL.prototype, {
return;
}
parse(scheme, kSchemeStart, null, ctx,
onParseProtocolComplete.bind(this));
onParseProtocolComplete.bind(this));
}
},
username: {
Expand Down Expand Up @@ -607,7 +607,7 @@ Object.defineProperties(URL.prototype, {
if (this[cannotBeBase])
return;
parse(path, kPathStart, null, this[context],
onParsePathComplete.bind(this));
onParsePathComplete.bind(this));
}
},
search: {
Expand Down