tools: remove custom buffer-constructor lint rule

This rule is no longer needed. ESLint's built in no-buffer-constructor rule is enabled instead. PR-URL: #25261 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · cjihrig · Dec 31, 2018 · Dec 28, 2018 · Dec 28, 2018 · Dec 31, 2018
commit ad10cc57ee5303761d6b35b1c6c68f16b60a9f99
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -27,7 +27,6 @@ rules:
       message: "Use an error exported by the internal/errors module."
   # Custom rules in tools/eslint-rules
   node-core/require-globals: error
-  node-core/buffer-constructor: error
   node-core/no-let-in-for-declaration: error
   node-core/lowercase-name-for-primitive: error
   node-core/non-ascii-character: error

diff --git a/test/parallel/test-eslint-buffer-constructor.js b/test/parallel/test-eslint-buffer-constructor.js
diff --git a/test/root.status b/test/root.status
@@ -31,7 +31,6 @@ parallel/test-domain-with-abort-on-uncaught-exception: SLOW
 parallel/test-env-var-no-warnings: SLOW
 parallel/test-error-reporting: SLOW
 parallel/test-eslint-alphabetize-errors: SLOW
-parallel/test-eslint-buffer-constructor: SLOW
 parallel/test-eslint-crypto-check: SLOW
 parallel/test-eslint-documented-errors: SLOW
 parallel/test-eslint-duplicate-requires: SLOW

diff --git a/tools/eslint-rules/buffer-constructor.js b/tools/eslint-rules/buffer-constructor.js