fs: extract start and end check into checkPosition #25264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
starkwang
approved these changes
Dec 29, 2018
lpinca
reviewed
Dec 29, 2018
lpinca
approved these changes
Dec 29, 2018
Member
addaleax
added
the
author ready
Member
|
Landed in 98ed23c |
addaleax
pushed a commit
that referenced
this pull request
Jan 9, 2019
PR-URL: #25264 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 9, 2019
PR-URL: #25264 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#25264 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.startandthis.endinReadStreammeet the same conditions, extract their check intocheckPositionfunction.Maybe we can use it to check
this.startinWriteStreamtoo(but may need to do other works).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes