[v10.x backport] http: send connection: close when closing conn #26627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. PR-URL: nodejs#26467
4 tasks
lpinca
approved these changes
Mar 13, 2019
Member
|
It might be better to also open this for 11.x land that first, wait a couple of releases and then also land this. |
Author
Member
Collaborator
Member
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/22218/ cc: @nodejs/lts |
Member
|
@lpinca @johanneswuerbach, is it possible that this change could cause ecosystem breakages? Just erring on the side of caution before landing this on v10.x. /cc @nodejs/lts |
Member
|
@BethGriggs I don't think so as the socket is destroyed anyway. cc: @nodejs/http |
Author
|
@BethGriggs as explained here #26467 (comment), I think this is mainly a bugfix to make node js http spec complaint and wouldn't expect any breakage as it merely adds a missing header. |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection. This adds the Connection: close header in the 400 responses sent on client errors. Backport-PR-URL: #26627 PR-URL: #26467 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
|
Landed on v10.x-staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of #26467 to v10
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes