doc: revise strict mode text in assert #28285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Trott
force-pushed
the
revise-strict-mode-yo
branch
from
f96e5f4 to
cfbd5f5
Compare
BridgeAR
approved these changes
Jun 19, 2019
Trott
added
the
author ready
trivikr
approved these changes
Jun 19, 2019
Revise the text describing `strict` mode. PR-URL: nodejs#28285 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Trott
force-pushed
the
revise-strict-mode-yo
branch
from
cfbd5f5 to
3af27f8
Compare
|
Landed in 3af27f8 |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Revise the text describing `strict` mode. PR-URL: #28285 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the text describing
strictmode.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes