Skip to content

test: update test-require-json.js #28358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: update test-require-json.js #28358

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c114f
test: use assert.throws() in test-require-json.js
alejandronanez Jun 21, 2019
0ab7845
fixup! test: update test-require-json.js
Trott Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: use assert.throws() in test-require-json.js 
Use assert.throws() instead of try/catch.
  • Loading branch information
@alejandronanez @Trott
alejandronanez authored and Trott committed Jul 30, 2019
commit 35c114ffe3c1ac79481fa1106c57defe5f2346d3
8 changes: 2 additions & 6 deletions test/parallel/test-require-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ require('../common');
const assert = require('assert');
const fixtures = require('../common/fixtures');

try {
assert.throws(function() {
require(fixtures.path('invalid.json'));
} catch (err) {
assert.ok(
/test[/\\]fixtures[/\\]invalid\.json: /.test(err.message),
`require() json error should include path: ${err.message}`);
}
}, SyntaxError);