Skip to content

[v10.x] tls: group chunks into TLS segments #28904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[v10.x] tls: group chunks into TLS segments #28904

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
100d8ef
doc,test: clarify that Http2Stream is destroyed after data is read
mildsunrise May 26, 2019
a7b4a6f
test: fix race in test-http2-origin
mildsunrise Jul 30, 2019
01a3271
tls: group chunks into TLS segments
mildsunrise May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix race in test-http2-origin 
PR-URL: #28903
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
@mildsunrise
mildsunrise committed Jul 30, 2019
commit a7b4a6f1704f11301e4e4543afbe789940b2bdae
14 changes: 9 additions & 5 deletions test/parallel/test-http2-origin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
['https://example.org', 'https://example.com']
];

const countdown = new Countdown(2, () => {
const countdown = new Countdown(3, () => {
client.close();
server.close();
});
Expand All @@ -101,7 +101,7 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
countdown.dec();
}, 2));

client.request().on('close', mustCall()).resume();
client.request().on('close', mustCall(() => countdown.dec())).resume();
}));
}

Expand All @@ -119,15 +119,19 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
const originSet = [`https://localhost:${server.address().port}`];
const client = connect(originSet[0], { ca });

const countdown = new Countdown(2, () => {
client.close();
server.close();
});

client.on('origin', mustCall((origins) => {
originSet.push(...check);
deepStrictEqual(originSet, client.originSet);
deepStrictEqual(origins, check);
client.close();
server.close();
countdown.dec();
}));

client.request().on('close', mustCall()).resume();
client.request().on('close', mustCall(() => countdown.dec())).resume();
}));
}

Expand Down