Skip to content

worker: keep allocators for transferred SAB instances alive longer #29637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

worker: keep allocators for transferred SAB instances alive longer #29637

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
615710b
worker: keep allocators for transferred SAB instances alive longer
addaleax Sep 20, 2019
e762ec7
fixup! worker: keep allocators for transferred SAB instances alive lo…
addaleax Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! worker: keep allocators for transferred SAB instances alive lo… 
…nger
  • Loading branch information
@addaleax
addaleax committed Sep 24, 2019
commit e762ec778bd6f9b0101696a8040953f17540fbf4
4 changes: 3 additions & 1 deletion src/sharedarraybuffer_metadata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ class SharedArrayBufferMetadata
// count is increased by 1.
v8::MaybeLocal<v8::SharedArrayBuffer> GetSharedArrayBuffer(
Environment* env, v8::Local<v8::Context> context);
std::shared_ptr<v8::ArrayBuffer::Allocator> allocator() { return allocator_; }
std::shared_ptr<v8::ArrayBuffer::Allocator> allocator() const {
return allocator_;
}

SharedArrayBufferMetadata(SharedArrayBufferMetadata&& other) = delete;
SharedArrayBufferMetadata& operator=(
Expand Down