http: IncomingMessage destroyed state #29855
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IncomingMessage should implement _destroy() instead of overriding destroy() in order to behave properly like a stream.
ronag
force-pushed
the
http-incoming-destroy
branch
from
44452a5 to
c74652f
Compare
|
This was supposed to go to my own fork. |
This was referenced Mar 11, 2021
This was referenced Apr 26, 2021
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IncomingMessage should implement _destroy() instead of overriding
destroy() in order to behave properly like a stream.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes