Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
4f41e4f
n-api: implement date object
jarrodconnolly Feb 4, 2019
f862276
n-api: make func argument of napi_create_threadsafe_function optional
legendecas May 21, 2019
859d475
src: reduce platform worker barrier lifetime
ofrobots Oct 11, 2018
a3eda28
doc: fixup changelog for v10.16.3
andrewhughes101 Aug 16, 2019
7735824
crypto: increase maxmem range from 32 to 53 bits
tniessen Jul 21, 2019
c74c6a5
n-api: mark version 5 N-APIs as stable
Sep 5, 2019
36a0e9a
http2: do not crash on stream listener removal w/ destroyed session
addaleax Sep 5, 2019
69b0212
http2: do not start reading after write if new write is on wire
addaleax Sep 1, 2019
15c2eb0
doc: update N-API version matrix
Sep 21, 2019
7f48519
deps: do not link against librt
sam-github Sep 26, 2019
56a834a
doc,test: clarify that Http2Stream is destroyed after data is read
mildsunrise May 26, 2019
f78ecc3
test: fix race in test-http2-origin
mildsunrise Jul 30, 2019
fe58bca
tls: group chunks into TLS segments
mildsunrise May 24, 2019
ccf2823
http: makes response.writeHead return the response
qubyte Feb 6, 2019
9258496
http2: makes response.writeHead return the response
qubyte Feb 6, 2019
2afbb3e
test,win: cleanup exec-timeout processes
joaocgreis Jul 16, 2019
cef5010
doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION
ckarande Jul 23, 2019
c285e69
doc: fix the links tls default version sections
ckarande Jul 24, 2019
b43d7e8
process: add --unhandled-rejections flag
BridgeAR Mar 11, 2019
2eae030
worker: add missing return value in case of fatal exceptions
BridgeAR Sep 24, 2019
9c393f1
deps: upgrade openssl sources to 1.1.1d
sam-github Oct 10, 2019
7202792
deps: update archs files for OpenSSL-1.1.1d
sam-github Oct 10, 2019
13d8549
test: well-defined DH groups now verify clean
sam-github Sep 13, 2019
69bf5b7
net: treat ENOTCONN at shutdown as success
addaleax Oct 10, 2019
85ce8ef
fs: remove experimental warning for fs.promises
addaleax Mar 11, 2019
333963e
deps: dlloads node static linked executable
lal12 Jun 4, 2019
ddb5152
stream: implement Readable.from async iterator utility
guybedford May 12, 2019
e8c90bf
zlib: do not coalesce multiple `.flush()` calls
addaleax Jul 3, 2019
66387cd
http2: send out pending data earlier
addaleax Sep 1, 2019
f1a5a36
build: update Windows icon to Feb 2016 rebrand
mikemaccana Jul 3, 2019
d6c998a
process: use public readableFlowing property
ckarande Sep 8, 2019
65e68d1
doc: add documentation for stream readableFlowing
ckarande Sep 9, 2019
1bb5102
src: use more explicit return type in Sign::SignFinal()
addaleax Oct 20, 2018
18b140a
src: use maybe version v8::Function::Call
oyyd Oct 23, 2018
00831f0
stream: make Symbol.asyncIterator support stable
mcollina Mar 29, 2019
79f3844
readline: make Symbol.asyncIterator support stable
mcollina Apr 1, 2019
fa27aac
dns: remove dns.promises experimental warning
cjihrig Mar 11, 2019
fcc22d3
dns: make dns.promises enumerable
cjihrig Mar 27, 2019
90fb146
doc: move dns.promises to stable status
cjihrig Mar 27, 2019
4f0f12c
crypto: fix rsa key gen with non-default exponent
sam-github Apr 4, 2019
03b6966
deps: upgrade npm to 6.10.0
Jul 3, 2019
e2291cf
deps: upgrade npm to 6.10.2
isaacs Jul 25, 2019
55cd01c
deps: update npm to 6.10.3
isaacs Aug 6, 2019
e53dbba
deps: update npm to 6.11.3
claudiahdz Sep 3, 2019
63de2ad
crypto: add support for chacha20-poly1305 for AEAD
chux0519 Nov 4, 2018
5dae3ef
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
BethGriggs Oct 1, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test,win: cleanup exec-timeout processes
When CMD is used to launch a process and CMD is killed too quickly,
the process can stay behind running in suspended state, never
completing. This only happens in Windows Server 2008R2.

Refs: nodejs/build#1829

PR-URL: #28723
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
joaocgreis authored and BethGriggs committed Oct 7, 2019
commit 2afbb3efabd74e1121784548862f52d5d78649f0
16 changes: 16 additions & 0 deletions test/parallel/test-child-process-exec-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,19 @@ cp.exec(cmd, { timeout: 2 ** 30 }, common.mustCall((err, stdout, stderr) => {
assert.strictEqual(stdout.trim(), 'child stdout');
assert.strictEqual(stderr.trim(), 'child stderr');
}));

// Workaround for Windows Server 2008R2
// When CMD is used to launch a process and CMD is killed too quickly, the
// process can stay behind running in suspended state, never completing.
if (common.isWindows) {
process.once('beforeExit', () => {
const basename = __filename.replace(/.*[/\\]/g, '');
cp.execFileSync(`${process.env.SystemRoot}\\System32\\wbem\\WMIC.exe`, [
'process',
'where',
`commandline like '%${basename}%child'`,
'delete',
'/nointeractive'
]);
});
}