doc: use the WHATWG URL API in http code examples #29917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
watson
added
the
author ready
BridgeAR
approved these changes
Oct 10, 2019
|
Upvote using 👍 here to approve fast-tracking |
cjihrig
approved these changes
Oct 10, 2019
jasnell
approved these changes
Oct 10, 2019
TimothyGu
reviewed
Oct 10, 2019
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3981/ (@nodejs/github-bot @richardlau It seems like the bot doesn't post the lite CIs automatically anymore for some time. It only posts the full CI runs.) |
trivikr
approved these changes
Oct 10, 2019
lpinca
approved these changes
Oct 10, 2019
devnexen
approved these changes
Oct 11, 2019
watson
added a commit
that referenced
this pull request
Oct 11, 2019
PR-URL: #29917 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]>
|
Landed in 5909532 |
@Trott I've reported it over in nodejs/github-bot#246. |
targos
pushed a commit
that referenced
this pull request
Oct 14, 2019
PR-URL: #29917 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes