Skip to content

esm: disable non-js exts outside package scopes #30501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 2 commits into from
Closed

esm: disable non-js exts outside package scopes #30501

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99dea2a
esm: disable non-js exts outside package scopes
guybedford Nov 15, 2019
2128632
include test
guybedford Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
include test
  • Loading branch information
@guybedford
guybedford committed Nov 15, 2019
commit 212863252c9799f944796ad39683d1fab68fd517
21 changes: 21 additions & 0 deletions test/es-module/test-esm-non-js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';

const common = require('../common');
const { spawn } = require('child_process');
const assert = require('assert');

const entry = require.resolve('./test-esm-json.mjs');

// Verify non-js extensions fail for ESM
const child = spawn(process.execPath, [entry]);

let stderr = '';
child.stderr.setEncoding('utf8');
child.stderr.on('data', (data) => {
stderr += data;
});
child.on('close', common.mustCall((code, signal) => {
assert.strictEqual(code, 1);
assert.strictEqual(signal, null);
assert.ok(stderr.indexOf('ERR_UNKNOWN_FILE_EXTENSION') !== -1);
}));