test: remove common.busyLoop() #30787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
Trott
approved these changes
Dec 4, 2019
devsnek
approved these changes
Dec 6, 2019
richardlau
approved these changes
Dec 6, 2019
cjihrig
added
the
author ready
PR-URL: nodejs#30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This commit replaces common.busyLoop() with sleep(). PR-URL: nodejs#30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in 4ec02d5...aa363c4. |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
PR-URL: #30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
This commit replaces common.busyLoop() with sleep(). PR-URL: #30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
This commit replaces common.busyLoop() with sleep(). PR-URL: #30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
This commit replaces common.busyLoop() with sleep(). PR-URL: #30787 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
benjamingr
added a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2022
This change makes the eventloopdelay test less flakey on some platforms by replacing a blocking-wait with a busy-wait which means the eventloop will always be positive increase. This is a partial revert of nodejs#30787 that returns the test to the state it had originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #30784 and #30783.This commit replaces
common.busyLoop()withsleep().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes