Skip to content

build: add mjs extension to lint-js #32145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: add mjs extension to lint-js #32145

wants to merge 1 commit into from

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Mar 8, 2020 •
edited
Loading

Checklist

@nschonni
build: add mjs extension to lint-js
d71ee24 
This matches what the lint-js make target passes through the CLI.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 8, 2020
@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2020
@addaleax
Copy link
Member

addaleax commented Mar 11, 2020

Landed in 641eac9

@addaleax addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@nschonni @addaleax
build: add mjs extension to lint-js
641eac9 
This matches what the lint-js make target passes through the CLI.

PR-URL: #32145
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@nschonni @MylesBorins
build: add mjs extension to lint-js
f60ec97 
This matches what the lint-js make target passes through the CLI.

PR-URL: #32145
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@nschonni @MylesBorins
build: add mjs extension to lint-js
fe34da8 
This matches what the lint-js make target passes through the CLI.

PR-URL: #32145
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@nschonni nschonni deleted the eslint-globs branch March 11, 2020 22:17
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 3, 2020
@nschonni @MylesBorins
build: add mjs extension to lint-js
26e44c9 
This matches what the lint-js make target passes through the CLI.

PR-URL: nodejs#32145
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
@nschonni @MylesBorins
build: add mjs extension to lint-js
45d05e1 
This matches what the lint-js make target passes through the CLI.

Backport-PR-URL: #32610
PR-URL: #32145
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Apr 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

+1 more reviewer

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.