async_hooks: add a method to expose all resources alive #32390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
legendecas
added
the
async_hooks
|
I’m not sure that this should end up under |
Add a new async_hooks.aliveResources() API. Returns an object map
of { <id>: <resource> }. Currently, it works for all async_hooks
resources except nextTick-s, which are probably not useful to expose
in this way.
Co-Author: Jeremiah Senkpiel <[email protected]>
legendecas
force-pushed
the
active-resources
branch
from
5a6ce1f to
0643830
Compare
|
@addaleax Can you elaborate on why this isn't expected to list the resources in the sense of async_hooks? AFAIK, these resources are the ones passed to the init hooks. |
legendecas
changed the title
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
async_hooks.aliveResources()API. Returns an object mapof
{ <id>: <resource> }.This API exposes
AsyncWrap#resourcebut notAsyncWrap#owner.AsyncWrap#resources are not the public API object. We shall expose these public ones instead.Co-Author: Jeremiah Senkpiel [email protected]
This PR is a pick up of #21453.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes