Skip to content

build: fix vcbuild error for missing Visual Studio #32658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build: fix vcbuild error for missing Visual Studio #32658

wants to merge 2 commits into from

Conversation

Hakerh400
Copy link
Contributor

The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio (because PR #26714 reordered sections in building.md)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Hakerh400
build: fix vcbuild error for missing Visual Studio
dde99e4 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Apr 4, 2020
addaleax pushed a commit that referenced this pull request Apr 27, 2020
@Hakerh400 @addaleax
build: fix vcbuild error for missing Visual Studio
4e87973 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@addaleax
Copy link
Member

Landed in 4e87973

@addaleax addaleax closed this Apr 27, 2020
@Hakerh400 Hakerh400 deleted the vcb branch April 28, 2020 05:06
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@Hakerh400 @BethGriggs
build: fix vcbuild error for missing Visual Studio
e1e3ae4 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@Hakerh400 @BridgeAR
build: fix vcbuild error for missing Visual Studio
606719f 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@Hakerh400 @BridgeAR
build: fix vcbuild error for missing Visual Studio
bd40a8b 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@Hakerh400 @BethGriggs
build: fix vcbuild error for missing Visual Studio
191747c 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@Hakerh400 @BethGriggs
build: fix vcbuild error for missing Visual Studio
91e30e3 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2020
@Hakerh400 @targos
build: fix vcbuild error for missing Visual Studio
7c3acbb 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@Hakerh400 @targos
build: fix vcbuild error for missing Visual Studio
b555a77 
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@bzoz bzoz bzoz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Hakerh400 @addaleax @jasnell @lpinca @gengjiawen @gireeshpunathil @bzoz @nodejs-github-bot