tls: move getAllowUnauthorized to internal/options #32917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from nodejs#32379 Signed-off-by: James M Snell <[email protected]>
sam-github
approved these changes
Apr 20, 2020
| return result.value; | ||
| } | ||
|
|
||
| function getAllowUnauthorized() { |
There was a problem hiding this comment.
Non-blocking nit: IMO the name isn't ideal since it also conditionally prints a warning. Unfortunately, an alternative name isn't coming to mind right away.
There was a problem hiding this comment.
We can rename later if one comes to mind
jasnell
added
the
author ready
jasnell
added a commit
that referenced
this pull request
Apr 22, 2020
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from #32379 Signed-off-by: James M Snell <[email protected]> PR-URL: #32917 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 14aa313 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from #32379 Signed-off-by: James M Snell <[email protected]> PR-URL: #32917 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from #32379 Signed-off-by: James M Snell <[email protected]> PR-URL: #32917 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from #32379 Signed-off-by: James M Snell <[email protected]> PR-URL: #32917 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Make it so that the allow unauthorized warning can be easily reused by the QUIC impl once that lands. Extracted from #32379 Signed-off-by: James M Snell <[email protected]> PR-URL: #32917 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that the allow unauthorized warning can be easily reused
by the QUIC impl once that lands.
Extracted from the QUIC PR: #32379
Signed-off-by: James M Snell [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes