n-api: fix false assumption on napi_async_context structures #32928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
added
test
legendecas
force-pushed
the
napi_callback_scope
branch
from
202e30d to
14deca7
Compare
napi_async_context should be an opaque type and not be used as same as node::async_context.
legendecas
force-pushed
the
napi_callback_scope
branch
from
14deca7 to
764e99f
Compare
4 tasks
addaleax
approved these changes
Apr 27, 2020
|
Landed in 307c67b |
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: #32928 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_async_context should be an opaque type and not be used as same as
node::async_context.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes