Skip to content

Conversation

puzpuzpuz
Copy link
Member

Checklist

Refs: #32863

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@puzpuzpuz puzpuzpuz added the test Issues and PRs related to the tests. label Apr 20, 2020
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sam-github
Copy link
Contributor

fast-track?

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30879/

@puzpuzpuz puzpuzpuz added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 21, 2020
puzpuzpuz added a commit that referenced this pull request Apr 21, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@puzpuzpuz
Copy link
Member Author

Landed in 7893c70

@puzpuzpuz puzpuzpuz closed this Apr 21, 2020
@puzpuzpuz puzpuzpuz deleted the mark-test-child-process-fork-args-as-flaky branch April 21, 2020 09:56
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
targos pushed a commit that referenced this pull request Apr 30, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants