Skip to content

stream: write should throw on unknown encoding #33075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: write should throw on unknown encoding #33075

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c47817
stream: write should throw on unknown encoding
ronag Apr 26, 2020
017b240
fixup: explicit decodeString=false
ronag Apr 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: explicit decodeString=false
  • Loading branch information
@ronag
ronag committed Apr 26, 2020
commit 017b240be38028406c5921b69739fec040a709df
1 change: 1 addition & 0 deletions test/parallel/test-stream-writable-write-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ function test(autoDestroy) {

{
const w = new Writable({
decodeStrings: false,
autoDestroy,
_write() {}
});
Expand Down