Skip to content

doc: remove AsyncWrap mentions from async_hooks.md #33249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
puzpuzpuz wants to merge 1 commit into from
Closed

doc: remove AsyncWrap mentions from async_hooks.md #33249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: remove AsyncWrap mentions from async_hooks.md 
AsyncWrap is a private API and should not be mentioned
in the documentation.
  • Loading branch information
@puzpuzpuz
puzpuzpuz committed May 5, 2020
commit 44d90fbdfce65f9269fe9eb54e0cf8b611cbdc34
4 changes: 2 additions & 2 deletions doc/api/async_hooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function before(asyncId) { }
// After is called just after the resource's callback has finished.
function after(asyncId) { }

// Destroy is called when an AsyncWrap instance is destroyed.
// Destroy is called when the resource is destroyed.
function destroy(asyncId) { }

// promiseResolve is called only for promise resources, when the
Expand Down Expand Up @@ -635,7 +635,7 @@ see the details of the V8 [PromiseHooks][] API.

Library developers that handle their own asynchronous resources performing tasks
like I/O, connection pooling, or managing callback queues may use the
`AsyncWrap` JavaScript API so that all the appropriate callbacks are called.
`AsyncResource` JavaScript API so that all the appropriate callbacks are called.

### Class: `AsyncResource`

Expand Down