Skip to content

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jun 9, 2020

Removed in 2bdeb88.

Refs: #30020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax addaleax added errors Issues and PRs related to JavaScript errors originated in Node.js core. dont-land-on-v10.x labels Jun 9, 2020
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 9, 2020
@addaleax addaleax added the worker Issues and PRs related to Worker support. label Jun 9, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

addaleax added a commit that referenced this pull request Jun 11, 2020
Removed in 2bdeb88.

Refs: #30020

PR-URL: #33810
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@addaleax
Copy link
Member Author

Landed in c4a33f7

@addaleax addaleax closed this Jun 11, 2020
@addaleax addaleax deleted the removed-sab-err branch June 11, 2020 19:52
codebytere pushed a commit that referenced this pull request Jun 18, 2020
Removed in 2bdeb88.

Refs: #30020

PR-URL: #33810
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Removed in 2bdeb88.

Refs: #30020

PR-URL: #33810
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. worker Issues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants