[v12.x] deps: V8: cherry-pick 7889803e82d3 #34214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
devsnek
approved these changes
Jul 6, 2020
jasnell
approved these changes
Jul 6, 2020
Author
|
Hi, how should I land this commit? I'm not very familiar with the workflow. Thanks! |
addaleax
added
the
author ready
Member
|
@zjiaz Don’t worry, somebody will land this for you once CI has passed :) |
Collaborator
richardlau
approved these changes
Jul 7, 2020
codebytere
force-pushed
the
v12.x-staging
branch
from
43d1d89 to
df592c4
Compare
addaleax
changed the title
codebytere
force-pushed
the
v12.x-staging
branch
from
b64963e to
3b1d9b3
Compare
Author
|
Hi, should I still just wait? Or there are something unfinished? Thanks! |
Original commit message:
[mips] Use t9 as the function call register.
on mips, we should use t9 when jump to a ExternalReference, because
the callee function will consider t9 as the function start address.
Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417
Auto-Submit: Yu Yin <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/master@{#63988}
Refs: v8/v8@7889803
Collaborator
BethGriggs
approved these changes
Aug 18, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Aug 18, 2020
Original commit message:
[mips] Use t9 as the function call register.
on mips, we should use t9 when jump to a ExternalReference, because
the callee function will consider t9 as the function start address.
Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417
Auto-Submit: Yu Yin <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/master@{#63988}
Refs: v8/v8@7889803
PR-URL: #34214
Fixes: #33703
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Member
|
Landed in e5049f2 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #33703
Refs: v8/v8@7889803
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes