Skip to content

doc: fix typo in assert.md #34316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: fix typo in assert.md #34316

wants to merge 1 commit into from

Conversation

@pastelmind
Copy link
Contributor

@pastelmind pastelmind commented Jul 12, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jul 12, 2020
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 14, 2020
addaleax pushed a commit that referenced this pull request Jul 15, 2020
@pastelmind @addaleax
doc: fix typo in assert.md
9fc8778 
PR-URL: #34316
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax
Copy link
Member

addaleax commented Jul 15, 2020

Landed in 9fc8778

@addaleax addaleax closed this Jul 15, 2020
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@pastelmind @cjihrig
doc: fix typo in assert.md
ff28428 
PR-URL: #34316
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@pastelmind @MylesBorins
doc: fix typo in assert.md
c28453a 
PR-URL: #34316
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@pastelmind @addaleax
doc: fix typo in assert.md
ad94cfd 
PR-URL: #34316
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@pastelmind @addaleax
doc: fix typo in assert.md
1d64c2c 
PR-URL: #34316
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

+3 more reviewers

@sapics sapics sapics approved these changes

@MrHeer MrHeer MrHeer approved these changes

@rexagod rexagod rexagod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@pastelmind @addaleax @jasnell @Trott @lpinca @tniessen @sapics @MrHeer @rexagod @nodejs-github-bot