Skip to content

net/streams: don't return the stream object from onStreamRead #34375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

net/streams: don't return the stream object from onStreamRead #34375

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0865a22
streams: don't return the stream object from onStreamRead
robey Jul 15, 2020
851667e
streams: fix 2nd instance
robey Jul 18, 2020
f646c23
add a link to the bug, by request
robey Jul 18, 2020
eea77a5
add a test that crashes without the fix.
robey Jul 19, 2020
98daa59
fix linter error
robey Jul 19, 2020
1440eae
add extra check in stream_base.cc to be extra sure.
robey Jul 19, 2020
965c0b4
undo "nice to have" which breaks some tests (sorry)
robey Jul 24, 2020
27bc342
give up on asserting that everyone sees the same error
robey Jul 24, 2020
4663458
make a guess about why new tests are failing
robey Jul 30, 2020
251a8c9
try removing the test completely
robey Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add extra check in stream_base.cc to be extra sure.
  • Loading branch information
@robey
robey committed Jul 24, 2020
commit 1440eaede05f3eb8cc64a1268d44db6ee718680e
3 changes: 2 additions & 1 deletion src/stream_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,8 @@ void CustomBufferJSListener::OnStreamRead(ssize_t nread, const uv_buf_t& buf) {
0,
StreamBase::SKIP_NREAD_CHECKS);
Local<Value> next_buf_v;
if (ret.ToLocal(&next_buf_v) && !next_buf_v->IsUndefined()) {
if (ret.ToLocal(&next_buf_v) && !next_buf_v->IsUndefined() &&
next_buf_v->IsArrayBufferView()) {
Copy link
Member

@ronag ronag Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might this be what's causing problems?

Copy link
Contributor Author

@robey robey Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense... ok, i reverted that part.

buffer_.base = Buffer::Data(next_buf_v);
buffer_.len = Buffer::Length(next_buf_v);
}
Expand Down