Skip to content

build: do not run auto-start-ci on forks #34650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build: do not run auto-start-ci on forks #34650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: do not run auto-start-ci on forks 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.
  • Loading branch information
@evanlucas
evanlucas committed Aug 6, 2020
commit 22b078f5e9cc6475e25f4ee1a0147d5a9f7c9918
1 change: 1 addition & 0 deletions .github/workflows/auto-start-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:

jobs:
startCI:
if: github.repository == 'nodejs/node'
Copy link
Contributor

@mmarchini mmarchini Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: github.repository == 'nodejs/node'
if: secrets.JENKINS_USER && secrets.JENKINS_TOKEN

Also not sure if it works. Feel free to try on nodejs/node-auto-test first (I can re-enable Actions there, just give me a ping).

Copy link
Contributor

@mmarchini mmarchini Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might need to be

Suggested change
if: github.repository == 'nodejs/node'
if: ${{ secrets.JENKINS_USER && secrets.JENKINS_TOKEN }}

https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#about-contexts-and-expressions

Copy link
Contributor Author

@evanlucas evanlucas Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.amrom.workers.devmunity/t/jobs-job-id-if-does-not-work-with-env-secrets/16928/5 It doesn't sound like it does work...

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
Expand Down