Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
cca0372
timers: allow timers to be used as primitives
lundibundi Jun 19, 2020
aaa6e43
Forces Powershell to use tls1.2
bzoz Jul 21, 2020
093a4b0
test: add tests for validateNumber/validateString
lundibundi Aug 7, 2020
9a7c87d
module: use cjsCache over esm injection
guybedford Aug 3, 2020
7cde699
doc: harden policy around objections
mmarchini Aug 5, 2020
b93ba07
doc: add writable and readable options to Duplex docs
preyunk Jul 15, 2020
2abc98e
build: add flag to build V8 with OBJECT_PRINT
mmarchini Apr 14, 2020
8766b5b
tools: add debug entitlements for macOS 10.15+
ggreco Jul 15, 2020
9527a2a
deps: V8: cherry-pick e06ace6b5cdb
addaleax Aug 7, 2020
27c0653
test: add vm crash regression test
addaleax Aug 7, 2020
77bbd73
util: add debug and debuglog.enabled
bmeck Jun 12, 2020
124a01d
lib: use full URL to GitHub issues in comments
Trott Aug 8, 2020
b261895
test: remove test-child-process-fork-args flaky designation
Trott Aug 8, 2020
d29b805
doc: update http server response 'close' event
renatomariscal Jul 21, 2020
9f0917e
test: use block-scoping in test/pummel/test-timers.js
Trott Aug 5, 2020
fd5153c
test: split test-crypto-dh-hash
Trott Aug 5, 2020
230bcaf
doc: add HPE_UNEXPECTED_CONTENT_LENGTH error description
nikolaykrashnikov Aug 1, 2020
8e91f3e
test: fix test_worker_terminate_finalization
addaleax Aug 11, 2020
91f5324
doc: use semantically appropriate tag for lines
aduh95 Aug 7, 2020
b00f71b
doc: add padding in the sidebar column
aduh95 Aug 7, 2020
3022e0d
src: prefer C++ empty() in boolean expressions
tniessen Jul 19, 2020
ea98122
doc: n-api environment life cycle APIs are stable
jschlight Aug 6, 2020
e4450a1
benchmark: update function_args addon code
addaleax Aug 11, 2020
201d3d7
build: cover all benchmark addons with C++ linter
addaleax Aug 11, 2020
6929649
module: custom --conditions flag option
guybedford Aug 5, 2020
f7563f8
doc: remove typo in crypto.md
Trott Aug 9, 2020
0472d16
test: skip node-api/test_worker_terminate_finalization
addaleax Aug 11, 2020
b933eef
doc: reduce repetitiveness on Consensus Seeking
mmarchini Aug 10, 2020
6ee2578
http2: add maxHeaderSize option to http2
preyunk May 29, 2020
15c9208
build: set --v8-enable-object-print by default
mmarchini Aug 10, 2020
8b56902
doc: edit (general) collaborator guide
Trott Aug 10, 2020
cb09606
doc: use sentence-casing for headers in collaborator guide
Trott Aug 10, 2020
8de6b72
benchmark: add benchmark script for resourceUsage
yashLadha Aug 9, 2020
698cae7
module: share CJS/ESM resolver fns, refactoring
guybedford Aug 9, 2020
8403118
policy: support conditions for redirects
bmeck Jul 17, 2020
aed8237
build: implement a Commit Queue in Actions
mmarchini Jun 29, 2020
9a79020
test: remove error message checking in test-worker-init-failure
Trott Aug 11, 2020
1a9496a
lib: add UNC support to url.pathToFileURL()
mceachen Aug 12, 2020
332e384
buffer: alias UInt ➡️ Uint in buffer methods
addaleax Aug 11, 2020
7ef5591
fs: guard against undefined behavior
ronag Aug 12, 2020
a78c638
test: use process.env.PYTHON to spawn python
addaleax Aug 9, 2020
69bcca1
crypto: avoid unitializing ECDH objects on error
tniessen Jul 10, 2020
3925fd6
doc: avoid _may_ in collaborator guide
Trott Aug 12, 2020
5009d82
test,doc: add missing uv_setup_args() calls
cjihrig Aug 12, 2020
d89a83c
build: move compiling for Windows ARM64 to Tier 2
joaocgreis Aug 11, 2020
2781f64
meta: add TSC as owner of governance-related docs
mmarchini Aug 11, 2020
e4a0e5b
module: fix check for package.json at volume root
DerekNonGeneric Aug 2, 2020
dbcb36d
errors: improve ERR_INVALID_OPT_VALUE error
lundibundi Aug 7, 2020
952f233
http: add RFC references for each status code
Voltra May 31, 2020
bdf26ae
build: add build flag for OSS-Fuzz integration
DavidKorczynski Aug 13, 2020
88919e5
test: allow ENFILE in test-worker-init-failure
Trott Aug 14, 2020
1c324d5
test: allow ENOENT in test-worker-init-failure
Trott Aug 14, 2020
c458e84
test: remove common.rootDir
Trott Aug 14, 2020
e54a684
doc: fix broken links in commit-queue.md
lpinca Aug 15, 2020
9ca4b2a
build: add CODEOWNERS linter action
mmarchini Aug 11, 2020
756c058
meta: fix codeowners docs path
mmarchini Aug 17, 2020
258f64f
doc: edit filehandle.close() entry in fs.md
Trott Aug 14, 2020
04defba
lib: allow to validate enums with validateOneOf
lundibundi Jun 26, 2020
03d6013
worker: do not crash when JSTransferable lists untransferable value
addaleax Aug 13, 2020
513ab0e
worker: fix --abort-on-uncaught-exception handling
addaleax Aug 11, 2020
7d0970c
doc,lib: remove unused error code
Trott Aug 15, 2020
e8eed5c
test: convert assertion that always fails to assert.fail()
Trott Aug 16, 2020
3bfe199
doc: remove "is recommended from crypto legacy API text
Trott Aug 9, 2020
47f2f45
doc: deprecate (doc-only) crypto.Certificate()
Trott Aug 16, 2020
7ed7ef7
test: move execution of WPT to worker threads
targos Aug 15, 2020
c080fc5
test: move test-inspector-already-activated-cli to parallel
Trott Aug 13, 2020
3360dcb
doc: fix some typos and grammar mistakes
HillaShx Aug 16, 2020
969fb1c
doc: improve async_hooks snippets
puzpuzpuz Aug 18, 2020
8f38c19
esm: improve error message of ERR_UNSUPPORTED_ESM_URL_SCHEME
lundibundi Aug 16, 2020
5c987ff
doc: fix file name to main.mjs and not main.js in esm.md
frank-dspeed Aug 15, 2020
b356b79
doc: reorder deprecated tls docs
jeromecovington Aug 9, 2020
7f0869f
build: run link checker in linter workflow
richardlau Aug 17, 2020
cdd4540
doc,tools: annotate broken links in actions workflow
richardlau Aug 17, 2020
34430ab
doc: move module core module doc to separate page
aduh95 Aug 7, 2020
6b45bf3
test: modernize test-cluster-master-error
addaleax Aug 8, 2020
90abdd3
net: validate custom lookup() output
cjihrig Aug 17, 2020
b73943e
workers: add support for data: URLs
aduh95 Jul 31, 2020
5214de7
doc: remove space above version picker
Vap0r1ze Aug 14, 2020
3133b75
doc: move addaleax to TSC emeritus
addaleax Aug 17, 2020
6048421
build,win: use x64 Node when building for ARM64
dennisameling Jun 22, 2020
a16f0f4
process: correctly parse Unicode in NODE_OPTIONS
bzoz Jul 22, 2020
9e0d18f
http2: use and support non-empty DATA frame with END_STREAM flag
clshortfuse Jun 14, 2020
2a78c33
test: run REPL preview test regardless of terminal type
Trott Aug 16, 2020
ef41ddf
doc: sort references lexically
Trott Aug 20, 2020
b1c3fb7
doc: fix bulleted list punctuation in BUILDING.md
Trott Aug 20, 2020
e16b3e7
test: fix test-cluster-net-listen-relative-path.js to run in /
Trott Aug 18, 2020
68b7a8d
deps: upgrade npm to 6.14.8
ruyadorno Aug 17, 2020
98f7d8e
n-api: handle weak no-finalizer refs correctly
Aug 19, 2020
e4679bd
doc: use 'console' info string for console output
Trott Aug 20, 2020
d6bb2ad
doc: adopt Microsoft Style Guide officially
Trott Aug 18, 2020
4b3b0e3
doc: fix ESM/CJS wrapper example
fox1t Aug 20, 2020
cc72584
http2: fix Http2Response.sendDate
joaolucasl Aug 20, 2020
e90cb49
tls: enable renegotiation when using BoringSSL
nornagon Aug 18, 2020
f2c2f42
doc: improve wording in deprecations.md
Trott Aug 21, 2020
bf7f492
doc: rename module pages
aduh95 Aug 7, 2020
7666d95
src: usage of modernize-use-equals-default
yashLadha Aug 17, 2020
fff1e7f
src: fix abort on uv_loop_init() failure
bnoordhuis Aug 22, 2020
dae93ca
doc: indicate the format of process.version
dguo Aug 22, 2020
9ebae0a
doc,n-api: add link to n-api tutorial website
jschlight Aug 21, 2020
ff15c92
doc: improve fs doc intro
jasnell Aug 19, 2020
cf34854
deps: upgrade to libuv 1.39.0
cjihrig Aug 25, 2020
a69d30e
module: drop `-u` alias for `--conditions`
richardlau Aug 26, 2020
cd32522
doc: add missing DEP ID for 'new crypto.Certificate()'
BethGriggs Aug 26, 2020
3153c2d
2020-08-27, Version 14.9.0 (Current)
Aug 20, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: allow ENFILE in test-worker-init-failure
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
  • Loading branch information
Trott authored and BethGriggs committed Aug 20, 2020
commit 88919e584b744e10b328428d8c45110fa2ae9039
8 changes: 5 additions & 3 deletions test/parallel/test-worker-init-failure.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ if (process.argv[2] === 'child') {
});

// We want to test that if there is an error in a constrained running
// environment, it will be one of `EMFILE` or `ERR_WORKER_INIT_FAILED`.
// environment, it will be one of `ENFILE`, `EMFILE`, or
// `ERR_WORKER_INIT_FAILED`.
const allowableCodes = ['ERR_WORKER_INIT_FAILED', 'EMFILE', 'ENFILE'];

// `common.mustCall*` cannot be used here as in some environments
// (i.e. single cpu) `ulimit` may not lead to such an error.

worker.on('error', (e) => {
assert.ok(e.code === 'ERR_WORKER_INIT_FAILED' || e.code === 'EMFILE');
assert.ok(allowableCodes.includes(e.code), `${e.code} not expected`);
});
}

Expand Down