tools: test-npm fixes for npm3 #3489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
test
Fishrock123
force-pushed
the
test-npm-fixes-for-npm3
branch
from
f69b0a0 to
6c9938b
Compare
|
lgtm, get it done and we'll shake it out in an RC |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 22, 2015
Refs: #3308 PR-URL: #3489 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Fishrock123
added a commit
that referenced
this pull request
Oct 22, 2015
Refs: #3308 PR-URL: #3489 Reviewed-By: Rod Vagg <[email protected]>
Fishrock123
force-pushed
the
test-npm-fixes-for-npm3
branch
from
6c9938b to
9b88864
Compare
rvagg
pushed a commit
that referenced
this pull request
Oct 22, 2015
Refs: #3308 PR-URL: #3489 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Fishrock123
added a commit
that referenced
this pull request
Oct 22, 2015
Refs: #3308 PR-URL: #3489 Reviewed-By: Rod Vagg <[email protected]>
|
should this be added to LTS? /cc @jasnell |
|
@thealphanerd no, this is only for npm@3. v4 uses npm@2. |
This was referenced Oct 27, 2015
Closed
|
@jasnell this is only useful for npm3... are we planning to backport that to lts? |
|
No, it shouldn't be backported. |
This was referenced Apr 29, 2023
This was referenced Jun 22, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel better about doing it this way.
replaces #3308
See: #3308 (comment)
cc @nodejs/build or anyone elase: any sign-off will do.