Skip to content

test: revise test-policy-integrity #35101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020
Merged

test: revise test-policy-integrity #35101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: revise test-policy-integrity 
* eliminate unneeded Set deletion/cleanup
* use number of CPUs as limit for processes spawned rather than
  hard-coding the limit

PR-URL: #35101
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
  • Loading branch information
@Trott
Trott committed Sep 10, 2020
commit 7fc1a4a893e080d0e55d7af9638938d00889dc24
5 changes: 3 additions & 2 deletions test/pummel/test-policy-integrity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const fs = require('fs');
const path = require('path');
const { pathToFileURL } = require('url');

const cpus = require('os').cpus().length;

function hash(algo, body) {
const values = [];
{
Expand Down Expand Up @@ -82,7 +84,7 @@ function queueSpawn(opts) {
}

function drainQueue() {
if (spawned > 50) {
if (spawned > cpus) {
return;
}
if (toSpawn.length) {
Expand Down Expand Up @@ -383,6 +385,5 @@ debug(`spawning ${tests.size} policy integrity permutations`);

for (const config of tests) {
const parsed = JSON.parse(config);
tests.delete(config);
queueSpawn(parsed);
}