Skip to content

module: Improves Top-Level await error in cjs #35196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

module: Improves Top-Level await error in cjs #35196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ lib/internal/v8_prof_polyfill.js
lib/punycode.js
test/addons/??_*
test/fixtures
test/message/cjs_top_await_error.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here because eslint doesn't play well with top-level await yet.

test/message/esm_display_syntax_error.mjs
tools/icu
tools/lint-md.js
Expand Down
5 changes: 5 additions & 0 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,6 +1203,11 @@ function wrapSafe(filename, content, cjsModuleInstance) {
} catch (err) {
if (process.mainModule === cjsModuleInstance)
enrichCJSError(err);
if (err.message.includes('await is only valid in async function')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if you plug in this code:

function x() {
  await 1;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/Users/mylesborins/code/node/main/lol.js:2
  await 1;
  ^^^^^

SyntaxError: Top-Level await is only supported in ESM.
    at wrapSafe (internal/modules/cjs/loader.js:1005:16)
    at Module._compile (internal/modules/cjs/loader.js:1058:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1115:10)
    at Module.load (internal/modules/cjs/loader.js:954:32)
    at Function.Module._load (internal/modules/cjs/loader.js:795:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47

Yeah, this is not good. Do you think there is a way to distinguish this without having to parse the entire file?

err.message = 'Top-Level await is only supported in ESM.';
err.stack = err.stack.replace(/SyntaxError:.*\n/,
`SyntaxError: ${err.message}\n`);
}
throw err;
}

Expand Down
4 changes: 4 additions & 0 deletions test/message/cjs_top_await_error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
'use strict';

await Promise.resolve();

13 changes: 13 additions & 0 deletions test/message/cjs_top_await_error.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*/test/message/cjs_top_await_error.js:3
await Promise.resolve();
^^^^^

SyntaxError: Top-Level await is only supported in ESM.
at wrapSafe (internal/modules/cjs/loader.js:**:**)
at Module._compile (internal/modules/cjs/loader.js:**:**)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:**:**)
at Module.load (internal/modules/cjs/loader.js:**:**)
at Function.Module._load (internal/modules/cjs/loader.js:**:**)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:**:**)
at internal/main/run_main_module.js:**:**