Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v14.14.0 proposal #35648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
v14.14.0 proposal #35648
Changes from 1 commit
f544f7ad6ba4ecebf390030c6b3e8cdc59b3a77d1ee8434d83c90b1a77f1e1e5d727f07e8fdd3fa171db8877430c9952422f1319993f947a2e67d65d53cfcdf552e5c16107287092756328c62451b988b01c9c5985dc84d76852979c74d4584c0ade863ba4be8fcbc8a55524602bf73eb3f15b728c94cabd34410b7305288cacca062755b67d1cdd46ff152cc865b024164477541082c5946b1eddf13e0b0747178e3b11a1fadcf21ad9aca64ebbdda19b3202992d0b937fa5d3a401b84d1d3f4cb2f6ff970975bc1bb3649d1b7ac809cd074a2ba434025fc859a2cb57e7afc5cad86d416f82989288f9dcd0b136939f8e83d2179200eff4a41d7500a3c7f8e78259b66284f0d16c17dd0c87776b8529a7775af7ab82fc40573410f354b6a9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Without this, the session is destroyed with the following error ``` Error [ERR_HTTP2_ERROR]: Protocol error at Http2Session.onSessionInternalError (internal/http2/core.js:756:26) Emitted 'error' event on ClientHttp2Session instance at: at emitClose (internal/http2/core.js:1010:10) at internal/http2/core.js:1048:7 at finish (internal/streams/writable.js:731:5) at processTicksAndRejections (internal/process/task_queues.js:80:21) { code: 'ERR_HTTP2_ERROR', errno: -505 } ``` The test then calls `session.close()` which tries to write to a destroyed socket. As a result, an unhandled `ECONNRESET` error is emitted in the v12 release line. PR-URL: #35482 Refs: #34859 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing