Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 5, 2021

The max-len rule often hampers readability rather than enhancing it. Few
developers are inconvenienced by lines longer than 80 characters. Let's
remove it.

The max-len rule often hampers readability rather than enhancing it. Few
developers are inconvenienced by lines longer than 80 characters. Let's
remove it.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 5, 2021
@lpinca
Copy link
Member

lpinca commented Apr 5, 2021

The max-len rule often hampers readability rather than enhancing it.

I disagree. Even Prettier recommends 80 characters per line.

@targos
Copy link
Member

targos commented Apr 5, 2021

I agree with @lpinca, but I also agree with @Trott :D. Prettier recommends 80 characters per line but also says that its option is not the same as enforcing a max-len rule.
I'm not okay with entirely removing the rule but I'm open to allowing more characters per line, up to 120.

@Yu02
Copy link

Yu02 commented Apr 5, 2021

I actually think that this is a good idea, or maybe we should keep it as a warning.

@benjamingr
Copy link
Member

People in favour of max-length - what's the problem with using word-wrapping in the editor? Is that insufficient for readability?

@Trott
Copy link
Member Author

Trott commented Apr 5, 2021

I disagree. Even Prettier recommends 80 characters per line.

On the other hand, standard does not enforce any maximum line length whatsoever.

@Trott Trott closed this Apr 5, 2021
@lpinca
Copy link
Member

lpinca commented Apr 5, 2021

People in favour of max-length - what's the problem with using word-wrapping in the editor? Is that insufficient for readability?

I think not all editors support wrapping at a specific column. Also code does not look the same if line breaks and indentions are missing.

@Trott Trott deleted the de-max-len branch September 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants