Skip to content

fs: stop fixing EPERM on Windows #38810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

fs: stop fixing EPERM on Windows #38810

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8186ba4
fs: stop fixing EPERM on Windows
RaisinTen May 25, 2021
abdadd3
move checks into functions
RaisinTen Jun 3, 2021
ea8e0a5
reindent
RaisinTen Jun 3, 2021
9596fdc
update comments
RaisinTen Jun 3, 2021
8975f3e
tmpdir: remove empty call
RaisinTen Jun 3, 2021
aedf3a9
fixup! tmpdir: remove empty call
RaisinTen Jun 3, 2021
838cad0
lint fix
RaisinTen Jun 3, 2021
ecac8c6
Apply suggestions from code review
RaisinTen Jun 3, 2021
f48b819
Apply suggestions from code review
RaisinTen Jun 3, 2021
f67b959
Apply suggestions from code review
RaisinTen Jun 3, 2021
d4e6c6e
lint fix
RaisinTen Jun 3, 2021
3e52248
Apply suggestions from code review
RaisinTen Jun 4, 2021
bd817e2
Apply suggestions from code review
RaisinTen Jun 4, 2021
d0173e5
tmpdir: remove `if` around `throw err`
RaisinTen Jun 4, 2021
e88bdbb
Apply suggestions from code review
RaisinTen Jun 5, 2021
a766a75
tmpdir: inline error logging function
RaisinTen Jun 5, 2021
8c76097
use InvalidStateError class
RaisinTen Jun 5, 2021
65657f2
isValidState -> validateState
RaisinTen Jun 5, 2021
befac4b
log error from tmpdir only once at max
RaisinTen Jun 7, 2021
3fe174f
||= ~> if
RaisinTen Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Antoine du Hamel <[email protected]>
  • Loading branch information
@RaisinTen @aduh95
RaisinTen and aduh95 authored Jun 3, 2021
commit ecac8c638190c8c1ca77010727c2c5a2d9ae3e95
44 changes: 8 additions & 36 deletions test/parallel/test-fs-rm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,15 +315,8 @@ function removeAsync(dir) {
err = _err;
}

try {
fs.chmodSync(dirname, 0o777);
} catch {
}

try {
fs.chmodSync(filePath, 0o777);
} catch {
}
try { fs.chmodSync(dirname, 0o777); } catch {}
try { fs.chmodSync(filePath, 0o777); } catch {}

if (!isValidState(fs.existsSync(filePath), err)) {
throw err;
Expand All @@ -341,15 +334,8 @@ function removeAsync(dir) {
fs.chmodSync(dirname, 0o444);

fs.rm(filePath, { force: true }, common.mustCall((err) => {
try {
fs.chmodSync(dirname, 0o777);
} catch {
}

try {
fs.chmodSync(filePath, 0o777);
} catch {
}
try { fs.chmodSync(dirname, 0o777); } catch {}
try { fs.chmodSync(filePath, 0o777); } catch {}

if (!isValidState(fs.existsSync(filePath), err)) {
throw err;
Expand Down Expand Up @@ -391,15 +377,8 @@ function removeAsync(dir) {
err = _err;
}

try {
fs.chmodSync(middle, 0o777);
} catch {
}

try {
fs.chmodSync(leaf, 0o777);
} catch {
}
try { fs.chmodSync(middle, 0o777); } catch {}
try { fs.chmodSync(leaf, 0o777); } catch {}

if (!isValidState(fs.existsSync(root), err)) {
throw err;
Expand All @@ -420,15 +399,8 @@ function removeAsync(dir) {
fs.chmodSync(middle, 0o555);

fs.rm(root, { recursive: true }, common.mustCall((err) => {
try {
fs.chmodSync(middle, 0o777);
} catch {
}

try {
fs.chmodSync(leaf, 0o777);
} catch {
}
try { fs.chmodSync(middle, 0o777); } catch {}
try { fs.chmodSync(leaf, 0o777); } catch {}

if (!isValidState(fs.existsSync(root), err)) {
throw err;
Expand Down