Skip to content

Conversation

targos
Copy link
Member

@targos targos commented Sep 9, 2021

Original commit message:

[compiler] Gracefully handle an unsupported situation

... by skipping the optimization instead of CHECK-failing.

Bug: v8:12188
Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132
Auto-Submit: Georg Neis <[email protected]>
Commit-Queue: Jakob Gruber <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#76741}

Refs: v8/v8@9a60704

Fixes: #40030

Original commit message:

    [compiler] Gracefully handle an unsupported situation

    ... by skipping the optimization instead of CHECK-failing.

    Bug: v8:12188
    Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132
    Auto-Submit: Georg Neis <[email protected]>
    Commit-Queue: Jakob Gruber <[email protected]>
    Reviewed-by: Jakob Gruber <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#76741}

Refs: v8/v8@9a60704
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 9, 2021
@targos
Copy link
Member Author

targos commented Sep 9, 2021

@gengjiawen was faster 😄
#40046

@targos targos closed this Sep 9, 2021
@targos targos deleted the fix-40030 branch September 9, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check failed: !holder_map.has_named_interceptor(). when running jest

2 participants