Skip to content

fs: fix error codes for fs.cp #41106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Dec 10, 2021
Merged

fs: fix error codes for fs.cp #41106

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59c80a2
fs: fix error codes for `fs.cp`
aduh95 Dec 7, 2021
0304ed4
add ESLint rule
aduh95 Dec 7, 2021
fd0af39
fixup! add ESLint rule
aduh95 Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! add ESLint rule
  • Loading branch information
@aduh95
aduh95 committed Dec 7, 2021
commit fd0af391a962bbe6f4c42fd840c61faab0ccfd53
4 changes: 2 additions & 2 deletions lib/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ rules:
message: "Please use `require('internal/errors').hideStackFrames()` instead."
- selector: "AssignmentExpression:matches([left.name='prepareStackTrace'], [left.property.name='prepareStackTrace'])"
message: "Use 'overrideStackTrace' from 'lib/internal/errors.js' instead of 'Error.prepareStackTrace'."
- selector: "ThrowStatement > NewExpression:matches([callee.name=/^ERR_[A-Z_]+$/]) > ObjectExpression:first-child:not(:has([key.name='message']):has([key.name='code']):has([key.name='syscall']))"
message: "The context passed into this error must have .code, .syscall and .message."
- selector: "ThrowStatement > NewExpression[callee.name=/^ERR_[A-Z_]+$/] > ObjectExpression:first-child:not(:has([key.name='message']):has([key.name='code']):has([key.name='syscall']))"
message: "The context passed into SystemError constructor must have .code, .syscall and .message."
no-restricted-globals:
- error
- name: AbortController
Expand Down