test: exclude ibm i tests until we resolve #41812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#39683 These are being worked, but we really should have marked flaky a long time ago in ordert to make then nightlies non-red. Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Feb 1, 2022
Trott
approved these changes
Feb 1, 2022
richardlau
approved these changes
Feb 1, 2022
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
VoltrexKeyva
approved these changes
Feb 1, 2022
|
Going to land based on fast track. |
mhdawson
added a commit
that referenced
this pull request
Feb 1, 2022
Refs: #39683 These are being worked, but we really should have marked flaky a long time ago in ordert to make then nightlies non-red. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41812 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
|
Landed in 1387bb5 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Refs: #39683 These are being worked, but we really should have marked flaky a long time ago in ordert to make then nightlies non-red. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41812 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Feb 15, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: nodejs#41812 Refs: nodejs#39683
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: #41812 Refs: #39683 PR-URL: #41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
bengl
pushed a commit
to bengl/node
that referenced
this pull request
Feb 21, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: nodejs#41812 Refs: nodejs#39683 PR-URL: nodejs#41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
bengl
pushed a commit
to bengl/node
that referenced
this pull request
Feb 21, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: nodejs#41812 Refs: nodejs#39683 PR-URL: nodejs#41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
bengl
pushed a commit
that referenced
this pull request
Feb 21, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: #41812 Refs: #39683 PR-URL: #41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
bengl
pushed a commit
that referenced
this pull request
Feb 22, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: #41812 Refs: #39683 PR-URL: #41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Refs: #39683 These are being worked, but we really should have marked flaky a long time ago in ordert to make then nightlies non-red. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41812 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Refs: #39683 These are being worked, but we really should have marked flaky a long time ago in ordert to make then nightlies non-red. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41812 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Refs: #39683 These are being worked, but we really should have marked flaky a long time ago in ordert to make then nightlies non-red. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41812 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 21, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: #41812 Refs: #39683 PR-URL: #41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 24, 2022
Correct the names of two tests that have been marked `FLAKY` on IBM i so they will actually be marked as such by the test runner. Refs: #41812 Refs: #39683 PR-URL: #41984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson [email protected]