Skip to content

node-api: run finalizers directly from GC #42651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmoroz wants to merge 10 commits into from
Closed

node-api: run finalizers directly from GC #42651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f144c01
node-api: run finalizers directly from GC
vmoroz Jun 23, 2023
929a0ef
fix disabling JS in finalizers
vmoroz Jun 23, 2023
e5e2a60
add unit test for pure finalizers
vmoroz Jun 23, 2023
41e61e1
add test to crash on GC state access and update docs
vmoroz Jul 7, 2023
f199c72
add CheckGCAccess calls where code may access GC
vmoroz Jul 21, 2023
2edf5af
fix code and test for Linux
vmoroz Aug 4, 2023
971b894
fix JS linter error to use assert.strictEqual
vmoroz Aug 18, 2023
5ef58d3
Address PR feedback
vmoroz Sep 27, 2023
03d16c7
remove Call_while_GC.txt that accidentally added
vmoroz Sep 27, 2023
25bfcaf
address PR feedback
vmoroz Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address PR feedback
  • Loading branch information
@vmoroz
vmoroz committed Sep 28, 2023
commit 25bfcaf9024b1ac3bcea78f60497e14ea4718784
2 changes: 1 addition & 1 deletion doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5453,7 +5453,7 @@ napi_status node_api_post_finalizer(napi_env env,

Returns `napi_ok` if the API succeeded.

Schedules `napi_finalize` callback to be called asynchronously in the
Schedules a `napi_finalize` callback to be called asynchronously in the
event loop.

Normally, finalizers are called while the GC (garbage collector) collects
Expand Down
8 changes: 2 additions & 6 deletions test/js-native-api/test_finalizer/test_fatal_finalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,5 @@ const { spawnSync } = require('child_process');
const child = spawnSync(process.execPath, [
'--expose-gc', __filename, 'child',
]);
if (common.isWindows) {
assert.strictEqual(child.signal, null);
assert.match(child.stderr.toString(), /Finalizer is calling a function that may affect GC state/);
} else {
assert.strictEqual(child.signal, 'SIGABRT');
}
assert.strictEqual(child.signal, common.isWindows ? null : 'SIGABRT');
assert.match(child.stderr.toString(), /Finalizer is calling a function that may affect GC state/);